BDsensor: adding support for new probe sensor BDsensor #6490

markniu · 2024-02-10T16:16:34Z

adding support BDsensor for Fast auto bed leveling leveling.
About BDsensor:
It can measure the bed distance at any point in real time without moving the z axis up and down.
now the fast auto bed leveling is stable for pull, there will be more new features like real time adjust and strain gauge in the future.https://github.com/markniu/Bed_Distance_sensor
Config: https://github.com/markniu/Bed_Distance_sensor/wiki/Installing-for-Klipper

Sineos · 2024-02-11T10:46:23Z

Thanks a lot for your contribution. Please also provide the signed off as per point 3 in "What to expect in a review" in master/docs/CONTRIBUTING.md

Also, it would need to come with an update of the documentation in the relevant chapters, e.g. "bed level" and "g-codes"

slaesh

cant review/test in a technical perspective.. just some code-quality/hygiene hints :)

I guess this project could need some proper linting rules ;)

slaesh · 2024-02-13T07:18:13Z

src/BD_sensor.c

+uint32_t delay_m = 20, homing_pose = 0;
+int sda_pin = -1, scl_pin = -1, z_ofset = 0;
+uint16_t BD_Data;
+//extern uint32_t timer_period_time;


can be removed? =)

slaesh · 2024-02-13T07:18:46Z

src/BD_sensor.c

+
+///////////BDsensor as endstop
+struct timer time_bd;
+#include "autoconf.h"


maybe move it up to all other imports?

slaesh · 2024-02-13T07:22:11Z

src/BD_sensor.c

+}
+void ndelay_bd(uint32_t nsecs)


Suggested change

}

void ndelay_bd(uint32_t nsecs)

}

void ndelay_bd(uint32_t nsecs)

slaesh · 2024-02-13T07:22:50Z

src/BD_sensor.c

+        ndelay_bd_c(nsecs);
+}
+
+unsigned short BD_Add_OddEven(unsigned short byte)


a little bit confusing to name a "short" byte =)) was wondering how a byte can have more than 8 (10) bits looking at the loop :)

slaesh · 2024-02-13T07:23:07Z

src/BD_sensor.c

+}
+void  BD_i2c_stop(void)


Suggested change

}

void BD_i2c_stop(void)

}

void BD_i2c_stop(void)

slaesh · 2024-02-13T07:23:23Z

src/BD_sensor.c

+uint16_t BD_i2c_read(void)
+{
+    uint16_t b = 1024;
+   // if(BD_read_flag==1014)


can be removed? :)

slaesh · 2024-02-13T07:24:13Z

src/BD_sensor.c

+    else
+        b=1024;
+
+#if 0


can be removed? or maybe add a speaking comment why this is present :)

slaesh · 2024-02-13T07:24:38Z

src/BD_sensor.c

+    uint8_t data[8];
+    uint16_t BD_z;
+
+    //if(BD_read_flag==1018)


can be removed?

slaesh · 2024-02-13T07:27:38Z

src/BD_sensor.c

+{
+    int addr=atoi((char *)args[2]);
+    BD_read_flag=addr;
+    if(addr==1015)


maybe all these const's should be an enum? 1015, 1023, 1024, .. so many number all over the place :))

github-actions · 2024-03-01T00:08:12Z

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review
If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

KevinOConnor · 2024-03-21T17:07:30Z

Thanks. Is this sensor based on the ldc1612 chip? There has been some work done on that chip at #6536 (and #6537).

My high-level feedback is that I think we need to integrate these efforts into a single "probe_eddy_current.py" type of module. I think we want to avoid having each probe implement their own implementations of PROBE, PROBE_ACCURACY, homing, etc.

-Kevin

markniu · 2024-03-22T03:13:05Z

hello Kevin, thanks!
this sensor is not based on ldc1612 chip, it is based on the TCA355G that is a traditional inductive proximity switch sensor chip, some other DAC chip and analog electrical component to change the eddy current, not like the ldc1612 which change the eddy frequency to measure the distance.

beside it can output the distance value or raw DAC data via the i2c port, it can also work as a switch sensor (just output low/high level in the sda pin) while homing, that helps to consumes low mcu usage.

with the new feature nozzle collision sensing that use the raw DAC value to adjust the z_offset automatically.

Thanks. Is this sensor based on the ldc1612 chip? There has been some work done on that chip at #6536 (and #6537).

My high-level feedback is that I think we need to integrate these efforts into a single "probe_eddy_current.py" type of module. I think we want to avoid having each probe implement their own implementations of PROBE, PROBE_ACCURACY, homing, etc.

-Kevin

markniu · 2024-03-22T03:48:01Z

I agree, and it is no problem to remove the PROBE and PROBE_ACCURACY in the BDsensor.py and use the PROBE, PROBE_ACCURACY in the probe.py.

markniu added 3 commits February 11, 2024 00:04

BDsensor: adding support for new probe sensor BDsensor

d0cc119

Update Makefile

8f3260c

Update Makefile

ba2c906

slaesh reviewed Feb 13, 2024

View reviewed changes

markniu added 4 commits February 14, 2024 23:24

add collision sensing feature and clear the unused code

c34a63e

update the documentation and gcode for BDsensor

fc617c4

update documentation and gcode for BDsensor

82e5d92

update documentation

3516099

github-actions bot added the reviewer needed label Mar 1, 2024

markniu added 2 commits March 4, 2024 11:52

add support nozzle collision sensing

e5708a1

Update BDsensor.md

3fe4787

markniu mentioned this pull request Mar 4, 2024

Issue with ramps 1.4 markniu/Bed_Distance_sensor#101

Closed

KevinOConnor added the pending feedback Topic is pending feedback from submitter label Mar 21, 2024

markniu mentioned this pull request Mar 22, 2024

Calibration problem markniu/Bed_Distance_sensor#106

Open

KevinOConnor removed the pending feedback Topic is pending feedback from submitter label Mar 30, 2024

benbender mentioned this pull request Aug 1, 2024

Kippler support markniu/Bed_Distance_sensor#1

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BDsensor: adding support for new probe sensor BDsensor #6490

BDsensor: adding support for new probe sensor BDsensor #6490

markniu commented Feb 10, 2024

Sineos commented Feb 11, 2024

slaesh left a comment

slaesh Feb 13, 2024

slaesh Feb 13, 2024

slaesh Feb 13, 2024

slaesh Feb 13, 2024

slaesh Feb 13, 2024

slaesh Feb 13, 2024

slaesh Feb 13, 2024

slaesh Feb 13, 2024

slaesh Feb 13, 2024

github-actions bot commented Mar 1, 2024

KevinOConnor commented Mar 21, 2024

markniu commented Mar 22, 2024 •

edited

Loading

markniu commented Mar 22, 2024

+                  else
+                      b=1024;
+              #if 0

BDsensor: adding support for new probe sensor BDsensor #6490

Are you sure you want to change the base?

BDsensor: adding support for new probe sensor BDsensor #6490

Conversation

markniu commented Feb 10, 2024

Sineos commented Feb 11, 2024

slaesh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Mar 1, 2024

KevinOConnor commented Mar 21, 2024

markniu commented Mar 22, 2024 • edited Loading

markniu commented Mar 22, 2024

markniu commented Mar 22, 2024 •

edited

Loading